Skip to content

Reword Suppress a Benign Warning section #126546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Reword Suppress a Benign Warning section #126546

merged 1 commit into from
Apr 11, 2025

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Apr 9, 2025

  • Remove advice related to Core/Infra and serverless
  • Prescribe the desired naming convention
  • Mention global uniqueness requirement

@prdoyle prdoyle added >docs General docs changes auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Apr 9, 2025
@prdoyle prdoyle self-assigned this Apr 9, 2025
@prdoyle prdoyle requested a review from a team as a code owner April 9, 2025 17:51
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Apr 9, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 9, 2025

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 9, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst
rjernst approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle merged commit e4b7b06 into main Apr 11, 2025
17 checks passed
@prdoyle prdoyle deleted the prdoyle-patch-2 branch April 11, 2025 18:51
This was referenced Apr 11, 2025
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 11, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Apr 11, 2025
@prdoyle
Reword Suppress a Benign Warning section (elastic#126546)
4cc00c0
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Apr 11, 2025
@prdoyle
Reword Suppress a Benign Warning section (elastic#126546)
2e9efdf
elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@prdoyle
Reword Suppress a Benign Warning section (#126546) (#126722)
3d0dee5
elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@prdoyle
Reword Suppress a Benign Warning section (#126546) (#126723)
963471a
elasticsearchmachine pushed a commit that referenced this pull request Apr 11, 2025
@prdoyle
Reword Suppress a Benign Warning section (#126546) (#126721)
7682186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

@prdoyle prdoyle

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prdoyle @elasticsearchmachine @rjernst